Translate directly from Cirq to C++ circuit.#135
Merged
95-martin-orion merged 3 commits intomasterfrom Jun 22, 2020
Merged
Conversation
Collaborator
Author
|
Of note: I deleted |
Collaborator
Author
|
Regarding missing checks: I think Github's "required checks" and the "only execute on C++ changes" rule for Bazel aren't cooperating. Options include (1) making Bazel checks optional, or (2) running Bazel checks even when no C++ changes are submitted. I'm not thrilled about it, but since (1) leaves holes in our test coverage I'll send out a PR for (2). (This might be good incentive for me to revisit issue #69...) |
Merged
sergeisakov
approved these changes
Jun 22, 2020
Collaborator
sergeisakov
left a comment
sergeisakov
left a comment
There was a problem hiding this comment.
Yes, this covers all of the gates_cirq gates except for MatrixGate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should cover all of the gates required by #134. It also explicitly deprecates the file-input format; although we do not currently plan to remove file input, we will no longer maintain it. Python users are encouraged to use Cirq; C++ users will need to interface directly with the qsim libraries.
@sergeisakov: please confirm that this covers all of the
gates_cirqgates (known exception:MatrixGate). If there are any other docs that need updating, let me know.Follow-up work (will open new issues for these):