Add initial docs and Dockerfiles for testing qsim installation.#20
Merged
95-martin-orion merged 7 commits intomasterfrom Mar 3, 2020
Merged
Add initial docs and Dockerfiles for testing qsim installation.#2095-martin-orion merged 7 commits intomasterfrom
95-martin-orion merged 7 commits intomasterfrom
Conversation
iamvamsikrishnad
changed the title
Collaborator
Author
|
TODO(@95-martin-orion): Document cmake and pybind11 prerequisites for installing qsim |
Closed
Collaborator
Author
|
TODO(@95-martin-orion): Update to reflect the requirements highlighted in #29. |
iamvamsikrishnad
approved these changes
Mar 3, 2020
+ interfaces/tests -> qsimcirq_tests + notes on post-install test process
Collaborator
Author
Done and done. As it stands, this is kind of awkward for a continuous test since it installs from the server, which presumably updates after a PR goes in. I'll align it with the "Install testing" process from #29 and add it to the Github test action. |
Collaborator
Author
|
@iamvamsikrishnad, I've added the tests to the continuous testing (with local install, i.e. |
iamvamsikrishnad
approved these changes
Mar 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To test this PR, run:
This may take a long time to complete, but in the end both tests should pass.
NOTE: This requires the qsim PyPI package to be updated - see #18 for details.