Fix shellcheck issues in two scripts#946
Merged
mhucka merged 3 commits intoquantumlib:mainfrom Nov 8, 2025
Merged
Conversation
Changes: - A past run of `addlicense` must have misshandled the hash-bang line in these shell scripts. - Some variables needed to be wrapped in double quotes.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly moves the shebang to the first line in both scripts, fixing a shellcheck issue. However, the changes to quote the CUSTATEVECFLAGS variable are incorrect and will break the build. Quoting a variable that contains multiple command-line options causes the shell to pass them as a single argument, rather than separate ones. My review provides critical feedback on these lines, explaining why the change is wrong and offering two solutions: the most robust one using bash arrays, and a more minimal one that reverts the incorrect change while correctly quoting other path variables. These changes are critical to ensure the scripts remain functional.
pavoljuhas
approved these changes
Nov 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes:
Reported by shellcheck.