Merged
Conversation
Collaborator
dstrain115
commented
May 20, 2025
dstrain115
commented
- Add descriptions and items for the perimeter zone for quantum rpg example.
- np.complex_ is no longer in mumpy 2.0 - Should use complex128 instead.
- Add descriptions and items for the perimeter zone.
cognigami
reviewed
May 21, 2025
Collaborator
cognigami
left a comment
cognigami
left a comment
There was a problem hiding this comment.
What fun! Have you been to Waterloo?
| "and you can see glimpses of something metallic beneath the\n" | ||
| "surface. The air here is unusually quiet, almost peaceful,\n" | ||
| "save for the faint, rhythmic lapping of waves against the shore,\n" | ||
| "like a steady, repetitive beat." |
Collaborator
There was a problem hiding this comment.
Delete "repetitive". Beats are rhythmic by definition, so they repeat.
| description=(""), | ||
| description=( | ||
| "This office once belonged to a theoretical physicist.\n" | ||
| "Scattered chalk dust and equations scribbled on the walls\n" |
Collaborator
Author
There was a problem hiding this comment.
I am not sure I understand the reference.
| "closed doors. The silence here is almost oppressive, broken\n" | ||
| "only by the occasional creak of the decaying structure. A faint\n" | ||
| "resonance seems to emanate from the west, a dull thrumming,\n" | ||
| "like a distant, repetitive calculation." |
Collaborator
There was a problem hiding this comment.
I wonder if the distant, dull thrumming would be evoked more strongly by a sound like a dot-matrix printer?
Collaborator
Author
There was a problem hiding this comment.
Good idea. Done.
| "equipment state that this mill was built in 1816 by one\n" | ||
| "of the early settlers in the area and now houses a museum\n" | ||
| "dedicated to the history of the area. Graffiti on one sign\n" | ||
| "states 'We all rotate, round and round, closer to the end'" |
Collaborator
There was a problem hiding this comment.
Period at the end of the sentence.
| "A sign over the entrance reads 'Quantum Computing:'\n" | ||
| "'The Technology of the Future'. Graffiti painted over\n" | ||
| "it reads 'BLACK HOLE SIGN WONT YOU COME AND WASH AWAY'" | ||
| "'MY ERROR RATE'" |
Collaborator
There was a problem hiding this comment.
Period at the end of the sentence.
dstrain115
commented
May 22, 2025
Collaborator
Author
dstrain115
left a comment
dstrain115
left a comment
There was a problem hiding this comment.
Thanks for the review! I have not been to Waterloo, but I took some notes from a former alumni....
| "A sign over the entrance reads 'Quantum Computing:'\n" | ||
| "'The Technology of the Future'. Graffiti painted over\n" | ||
| "it reads 'BLACK HOLE SIGN WONT YOU COME AND WASH AWAY'" | ||
| "'MY ERROR RATE'" |
| "equipment state that this mill was built in 1816 by one\n" | ||
| "of the early settlers in the area and now houses a museum\n" | ||
| "dedicated to the history of the area. Graffiti on one sign\n" | ||
| "states 'We all rotate, round and round, closer to the end'" |
| "closed doors. The silence here is almost oppressive, broken\n" | ||
| "only by the occasional creak of the decaying structure. A faint\n" | ||
| "resonance seems to emanate from the west, a dull thrumming,\n" | ||
| "like a distant, repetitive calculation." |
Collaborator
Author
There was a problem hiding this comment.
Good idea. Done.
| description=(""), | ||
| description=( | ||
| "This office once belonged to a theoretical physicist.\n" | ||
| "Scattered chalk dust and equations scribbled on the walls\n" |
Collaborator
Author
There was a problem hiding this comment.
I am not sure I understand the reference.
| "and you can see glimpses of something metallic beneath the\n" | ||
| "surface. The air here is unusually quiet, almost peaceful,\n" | ||
| "save for the faint, rhythmic lapping of waves against the shore,\n" | ||
| "like a steady, repetitive beat." |
Collaborator
Author
|
@cognigami Any further comments? If not, can you approve? Thanks! |
cognigami
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.