-
Notifications
You must be signed in to change notification settings - Fork 3k
Do not attempt to set null system properties #47489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not attempt to set null system properties #47489
Conversation
|
Thanks for your pull request! Your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
|
Platform test job is in the job list, but it was skipped. >:( I'll try rebasing. |
8828007 to
7e4e449
Compare
|
This moves the 'config is null' failure to camel code but doesn't get azure-grouped to green: |
Status for workflow
|
| Status | Name | Step | Failures | Logs | Raw logs | Build scan |
|---|---|---|---|---|---|---|
| ✖ | Platform Tests - JDK 17 | Test Platform |
Failures | Logs | Raw logs | 🚧 |
Full information is available in the Build summary check run.
You can consult the Develocity build scans.
Failures
⚙️ Platform Tests - JDK 17 #
- Failing: Root module
📦 Root module
✖ Failed to execute goal io.quarkus:quarkus-platform-bom-maven-plugin:0.0.119:invoke-platform-project (build-platform-project) on project quarkus-platform-config: Failed to build the platform project, please consult the errors logged above.
📦 quarkus-platform/generated-platform-project/quarkus-camel/integration-tests/camel-quarkus-integration-test-aws2-grouped
✖ org.apache.camel.quarkus.component.aws.secrets.manager.it.GroupedCamelContextRefreshOnSecretRefreshTest. - History - More details - Source on GitHub
Details
java.util.ServiceConfigurationError: io.smallrye.config.SmallRyeConfigFactory: io.quarkus.runtime.configuration.QuarkusConfigFactory not a subtype
at java.base/java.util.ServiceLoader.fail(ServiceLoader.java:593)
at java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNextService(ServiceLoader.java:1244)
at java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNext(ServiceLoader.java:1273)
at java.base/java.util.ServiceLoader$2.hasNext(ServiceLoader.java:1309)
at java.base/java.util.ServiceLoader$3.hasNext(ServiceLoader.java:1393)
at io.smallrye.config.SmallRyeConfigProviderResolver.getFactoryFor(SmallRyeConfigProviderResolver.java:102)
at io.smallrye.config.SmallRyeConfigProviderResolver.getConfig(SmallRyeConfigProviderResolver.java:78)
📦 quarkus-platform/generated-platform-project/quarkus-camel/integration-tests/camel-quarkus-integration-test-kubernetes
✖ org.apache.camel.quarkus.component.kubernetes.it.KubernetesConfigMapContextReloadTest.configMapTriggersCamelContextReload line 84 - History - More details - Source on GitHub
Details
org.awaitility.core.ConditionTimeoutException:
Assertion condition defined as a Lambda expression in org.apache.camel.quarkus.component.kubernetes.it.KubernetesConfigMapContextReloadTest 1 expectation failed.
Response body doesn't match expectation.
Expected: is "reloaded"
Actual: not-reloaded
within 1 minutes.
at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
|
OK, let's be strict for now and we will see how it pans out. |
I agree. I think it's worth merging (and probably backporting) #47482, just to give a better-looking and more useful error message, but there's something underlying that needs to be fixed... probably caused by the classloading changes. :) My plan for today is to dig into it more. |
Alternate fix for #47475