Add support for ENC424J600 with bumped minimq#156
Merged
ryan-summers merged 20 commits intodevelopfrom Sep 30, 2021
Merged
Conversation
(afdab5f) cargo: include enc424j600 dependencies (39e0b55) main: feature gate different eth device (e845f56) nal: implement enc424j600 variant (befe70a) nal: fix unnecessary w5500 dependencies (20efdcc) settings: override eeprom MAC (0d90470) use cargo fmt (6e13f4f) cargo: add w5500 as default (83380a9) cargo: simplify smoltcp dependency (83109c3) settings/mac: remove redundant code (a3db62f) mac: use smoltcp (15f0964) eth_cfg: split off from main (4ae6e82) nal: migrated to enc424j600 (e66d916) phy_config: minor fix (3869217) clean up
* This also tells the ENC424J600 driver to use Cortex-M instructions to perform SPI CS_n delays at the current firmware CPU clock frequency.
* mqtt_control: Also fix missing feature gate for W5500
Contributor
Author
|
With 8055090, I've edited the GitHub workflows matrix such that |
ryan-summers
approved these changes
Sep 27, 2021
Member
ryan-summers
left a comment
ryan-summers
left a comment
There was a problem hiding this comment.
This is looking good to me, although I have no means of testing this code. If your testing is looking good, I'm happy to merge these additions.
ryan-summers
approved these changes
Sep 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of a careless mistake in my .git/config, I have pushed a merge of my original PR #154 to this upstream remote, which inadvertently also merged and closed that PR. This was never an intention and my PR still requires final review and confirmation by @ryan-summers and/or @jordens.
Therefore, I am opening a duplicate PR here, with some minor additional commits to what has already been reviewed in #154. Prior to this merge, I have force-pushed this upstream
developbranch back to the original head (4ef6c80). Please kindly make all necessary corrections/actions if this is still the wrongdevelophead - Thank you with much apologies!Summary
This PR is directly cloned from #154.
Key Changes
(based on #154)
phy_enc424j600for implementing MQTT client functionality with ENC424J600 controllerminimqto quartiq/minimq@d2ec3e8Testing
Network connection and MQTT features remain functional for both ENC424J600 variant on v1.4 User IFC board and W5500 variant on v1.3 User IFC board (using default crate features).
Issues to be resolved independently
close()), meaning in#[telemetry]the MQTT client will keep callingpublish()to queue in the socket TX buffer until it is full, and keep emittingWriteFailerrors.