Refactoring settings to enable USB control of runtime-settings#403
Merged
Refactoring settings to enable USB control of runtime-settings#403
Conversation
jordens
requested changes
Jun 18, 2024
ryan-summers
commented
Jun 19, 2024
ryan-summers
commented
Jun 19, 2024
Member
Author
|
@jordens This should now be good to go. |
jordens
requested changes
Jun 20, 2024
Co-authored-by: Robert Jördens <rj@quartiq.de>
…o feature/usb-settings
jordens
approved these changes
Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #380 by allowing RF channel settings to be configured via the USB port.
TODO:
serial-settingswill always say that you need to reboot to apply settings. This isn't true for runtime settings.Save RF channel transforms into the RF channel EEPROM, not device flashclearreset the RF channel configurations