Fix Windows path-separator leak in brand logo path resolution#378
Merged
Conversation
with_path_relative_to joined the base directory with Path::join and converted via to_string_lossy, which yields native backslash separators on Windows. Same root-cause family as the fix in PR #340 (pampa's quarto_api path resolution): also swaps Path::is_absolute() for quarto_util::is_rooted(), which is has_root()-based and correct on wasm32 targets where is_absolute() misfires.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, BrandLogoResource::with_path_relative_to joined the base
directory with Path::join and converted via to_string_lossy, which
yields native backslash separators. Downstream consumers (and the
crate's own tests) expect forward-slash paths.
Same root-cause family as #340 (pampa's quarto_api path resolution):
also swaps Path::is_absolute() for quarto_util::is_rooted(), which is
has_root()-based and correct on wasm32 targets where is_absolute()
misfires.