fix(revealjs): normalize line endings in vendored-asset drift test#386
Merged
Conversation
The test byte-compared the include_str!-embedded reveal assets against the npm dist copy. On a Windows checkout, core.autocrlf rewrites the committed-LF vendored files to CRLF on disk, so the embedded bytes gain CRLF while the npm copy stays LF -- a false mismatch on line endings alone. These assets are served verbatim and CRLF vs LF is irrelevant to browsers; the test's job is to catch content drift when reveal.js is bumped, not line endings. Normalize both sides before comparing so only real drift fails.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
vendored_reveal_assets_match_npm_packagetest byte-compares the reveal.jsassets embedded via
include_str!against the copy innode_modules/reveal.js/dist. On a Windows checkout withcore.autocrlf=true,git rewrites the committed-LF vendored files to CRLF on disk, so the embedded
bytes gain CRLF while the npm copy stays LF — the test fails on line endings
alone, with no actual content divergence.
These assets are served verbatim and CRLF vs LF is irrelevant to browsers; the
test exists to catch content drift when reveal.js is bumped, not line endings.
Normalize both sides before comparing so only real drift fails.
Test Plan
core.autocrlf=true),cargo nextest run -p quarto-core vendored_reveal_assets_match_npm_packagepasses