Update roundtrip snapshots pandoc 3.10#1062
Open
cderv wants to merge 2 commits into
Open
Conversation
Quarto's pre-release bundles Pandoc 3.10, which changes two Markdown writer behaviors exercised by the visual-editor roundtrip snapshot tests: - Display math: Pandoc 3.10 restores the pre-3.7 behavior of keeping the newlines inside $$...$$ (jgm/pandoc#11384, the regression was introduced in 3.7 and reverted in 3.9). The snapshots had been updated in quarto-dev#944 to the collapsed single-line form produced by Pandoc 3.8.3; 3.10 reverts that, which matches the original quarto-dev#790 snapshots. - Definition lists: with four_space_rule disabled (Quarto's default), Pandoc 3.10 indents definition content by 1 space instead of 3 (jgm/pandoc commit 8ce63ff). Regenerate the two affected snapshots (valid-basics-2 and valid-nesting) to match Pandoc 3.10 output.
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Member
Author
|
Probably to merge once pre-release becomes release, as test is failing now on Release only (which is expected) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates the two visual-editor roundtrip snapshots affected by Quarto's move to Pandoc 3.10 (pre-release):
roundtripped-valid-basics-2.qmdroundtripped-valid-nesting.qmdWhy
Pandoc 3.10 changes two Markdown-writer behaviors these snapshots exercise:
Display math — Pandoc 3.7 started collapsing block math
$$…$$onto a single line (display math newlines removed in Markdown output (3.7 vs 3.6.4) jgm/pandoc#11384). It was reverted in Pandoc 3.9 (jgm/pandoc@8123be6), restoring the pre-3.7 multi-line form. Quarto jumped from Pandoc 3.6.3 to 3.8.3 in 1.9.x — skipping 3.9 — so the snapshots were updated in Fix failing tests after Quarto 1.9 release #944 to the collapsed 3.8.3 output. Pandoc 3.10 reverts that, so the math here goes back to multi-line. Note this is identical to the original snapshots added in Snapshot test function improvements and more snapshot tests! #790 (which were generated with Pandoc 3.6.3).Definition lists — with
four_space_ruledisabled (Quarto's default), Pandoc 3.10 indents definition content by one space instead of three (jgm/pandoc@8ce63ff). This is a new, intended change (not a revert). Pandoc deactivated four space rule in jgm/pandoc@add83e8 but missed a case for definition list I believe.The table change in
valid-nestingis a consequence of (1): the display-math cell reflows, which narrows the column.Notes
Alternative for the definition-list change: enable
+four_space_rulein the visual editor's Markdown writer format to keep 4-space indentation stable across Pandoc versions. Left out here since it changes real output, not just tests. And I don't think we want this.gitignore addition is because I use roborev and this is needed