test: close ACP contract coverage - #108
Merged
zatevakhin merged 2 commits intoAug 30, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
zatevakhin
added a commit
that referenced
this pull request
Sep 1, 2026
* test: close ACP contract coverage * test: preserve exact ACP contract assertions
zatevakhin
added a commit
that referenced
this pull request
Sep 5, 2026
* refactor: introduce application runtime crate * refactor: split runtime lifecycle modules * test: colocate runtime module coverage * refactor: route legacy tools through shared parser * refactor: centralize tool detail behavior * fix: keep tool detail parsing production-aligned * test: retain UTF-8 replay coverage * refactor: move legacy state helpers to app * test: cover ACP replay edge cases * fix: make ACP replay cards idempotent * fix: dedupe terminal ACP thinking replays * test: migrate phase 2 slice 4 response coverage * test(ui): use native ACP fixtures * refactor: remove legacy server message reducer * test: restore native session state coverage * fix: discover nested session parents on load * refactor: extract phase 3 domain types * refactor: extract session domain types * refactor: extract semantic tool details * test: cover semantic tool detail regeneration * refactor: complete semantic tool previews * fix: keep tool detail parsing filesystem-free * refactor: extract chat domain entries * refactor: extract model and profile domain types * refactor: remove model profile protocol bridges * refactor: remove domain compatibility bridges * refactor: extract auth domain core * test: cover oauth auth-method command serialization * refactor: separate session page wire types * test: strengthen session page adapter coverage * test: align session adapters with active ingress * refactor: separate session mutation results * fix: preserve rejected undo frontier * refactor: separate oauth domain state * fix: separate auth ui feedback * test: tighten auth ui state coverage * test: cover auth notice transitions * test: cover auth ui notice resets * refactor: introduce internal command seam * fix: centralize session command mapping * refactor: complete internal command bus migration * fix: remove orphan pending command queue * refactor: remove legacy protocol scaffolding * fix: narrow legacy protocol cleanup * refactor: separate mesh domain values * fix: align remote session contracts * fix: honor ACP session list contract * refactor: separate delegation notification values * refactor: split protocol contracts * refactor: complete phase 3 acceptance cleanup * refactor: extract diagnostics state * refactor: extract auth state * refactor: extract profiles state * refactor: extract mesh state * refactor: extract navigation state * refactor: extract models state * refactor: extract sessions state * refactor: extract connection state * refactor: extract composer state * refactor: extract delegates state * refactor: extract chat state owner * refactor: extract render state * refactor: centralize application effects * fix: address application effect review * fix: preserve phase 5 effect ordering * fix: make effect scheduling fair * fix: remove terminal event drain starvation * refactor: split the ACP subsystem (#95) * refactor: establish acp subsystem boundaries * refactor: isolate acp jsonrpc transport contracts * refactor: extract acp runtime and extensions * refactor: route acp commands and transports * test: close acp lifecycle contracts * fix: preserve websocket prompt failures on teardown * fix: satisfy websocket teardown lint * fix: satisfy replay buffer clippy lint * refactor: extract feature reducers (#96) Squash-integrates the independently reviewed Phase 7 feature reducer extraction from refactor/feature-reducers. * refactor: separate domain and rendering (#97) Integrate the approved Phase 8 domain/rendering separation into refactor/components. Source validation and hosted CI are green; preserve the reviewed source branch for provenance. * refactor: split input and UI by feature (#99) Integrate the approved Phase 9 input and UI feature split into refactor/components. Source validation and hosted CI are green; preserve the reviewed source branch for provenance. * test: harden persistence isolation (#100) Integrate the independently approved Phase 10 persistence-safety baseline into refactor/components. The exact source is test-only, local and hosted validation are green, and the retained source branch preserves provenance. * test: colocate start-page session input tests (#101) * test: colocate start-page session input tests * test: preserve session input adapter coverage * test: colocate session popup input tests (#102) * test: colocate session popup input tests * test: preserve session popup toggle routing * test: strengthen new session input contracts Squash-integrates the independently approved corrected Phase 10 New Session test-contract range. * test: colocate delegate input tests Squash-integrates the independently approved Phase 10 Delegate input test-ownership slice after successful hosted CI. * test: colocate delegate renderer tests Moves seven Delegate-only Ratatui renderer contracts to the Delegate owner module while retaining root UI composition and cross-feature contracts. * test: colocate elicitation and state tests (#106) * test: colocate elicitation and state tests * test: preserve state input edge contracts * test: colocate chat renderer tests (#107) * test: close ACP contract coverage (#108) * test: close ACP contract coverage * test: preserve exact ACP contract assertions * refactor: complete architecture cleanup (#109) * refactor: remove migration forwarding helpers * refactor: remove temporary test re-exports * refactor: enforce crate dead-code checks * ci: enforce architecture boundaries * docs: document module and event flow * ci: close dead-code policy bypass * ci: scan every crate inner attribute * ci: remove architecture boundary check * fix(tui): batch terminal events to reduce input lag Replace cancellation-sensitive EventStream polling with a bounded terminal event queue and coalesce compatible input events between redraws. Preserve scheduler fairness and rendering-dependent behavior by limiting batches by count and duration, deferring incompatible events, and pausing terminal input while the external editor is active. * fix: address CodeRabbit security and correctness findings Redact sensitive command data, harden Unicode and timestamp rendering, and clamp popup geometry for small terminals. Make editor handoff and JSON-RPC requests failure-safe, preserve event ordering, and fix state, arithmetic, diagnostics, and protocol robustness issues. * chore: flake.lock update * fix(acp): keep long-running prompts correlated until completion Exclude session/prompt from the generic WebSocket response timeout so terminal responses are not discarded after 60 seconds. Scope prom')pt failures by session, finalize failed turns, and ignore stale failures that could otherwise leave the UI stuck in streaming state. * test(ui): add deterministic ratatui snapshot coverage - add geometry-preserving buffer test helpers - snapshot start, help, and diagnostics views - replace crude text searches with cell and region assertions - use fixed render state and log timings for deterministic tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
287dbcf77bb9c39e366414b90b0015d3b3db99b2and the separate assertion/synchronization correction3f351251f507b905358745f0261883de416a1245.querymt/models/changedrouting; exact failed-tool fallback output; and normalized stdio/WebSocket event parity.+1771/-61) with production prefixes byte-identical.Validation
1,148 -> 1,168;cargo test --all-targetspassed 1,168 tests.cargo test --all-featuresandcargo test --all-features --releaseeach passed 1,168 tests twice.-D warnings, build, diff, scope, protected-path, and production-prefix gates passed.Residuals
Subprocess stdio framing/process failure, live ACP/backend, compatible external WebSocket, terminal, clipboard, and interactive UI smoke remain unavailable and are not claimed.