fix(converter): trailing empty <p> separator 건너뛰기를 layout 컨테이너에 확장합니다#971
Merged
fix(converter): trailing empty <p> separator 건너뛰기를 layout 컨테이너에 확장합니다#971
Conversation
기존에는 [document] 레벨에서만 trailing empty <p> separator 건너뛰기가 적용되어, ac:layout-cell 내부에서 N개의 trailing empty <p>가 N+1개의 blank line을 생성했습니다. 이로 인해 reverse-sync verify에서 trailing blank line 수가 불일치하여 roundtrip 검증에 diff가 발생했습니다 (544178422). ac:layout, ac:layout-section, ac:layout-cell을 투명 래퍼로 인식하여 N → N 매핑을 보장합니다. 영향받는 테스트 fixture를 함께 갱신합니다. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jk-kim0
force-pushed
the
jk/fix-sidecar-empty-block-mapping
branch
from
ad47157 to
96e4a18
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- isu_001 (confluence-mdx/tests/testcases/544112828/expected.mdx:296): fixture의 공백 줄 수를 바꾸면서 expected.roundtrip.json은 갱신하지 않아 forced-splice golden이 깨졌습니다. CI의 test_reverse_sync_byte_verify.py::TestSpliceRealTestcases::test_all_testcases_splice_byte_equal가 544112828에서 byte_mismatch_splice로 실패합니다.
- isu_001 (confluence-mdx/tests/testcases/544112828/expected.mdx:296): fixture의 공백 줄 수를 바꾸면서 expected.roundtrip.json은 갱신하지 않아 forced-splice golden이 깨졌습니다. CI의 test_reverse_sync_byte_verify.py::TestSpliceRealTestcases::test_all_testcases_splice_byte_equal가 544112828에서 byte_mismatch_splice로 실패합니다.
Contributor
Author
|
[debate-review][sha:96e4a18c027c87fd0f3d1e9f2f79849ce47f440d] Consensus reached after 3 rounds. Debate Summary
Applied Fixes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_is_trailing_empty_p가[document]레벨에서만 작동하여ac:layout-cell내부 trailing empty<p>에서 N+1 blank line이 생성되던 문제를 수정합니다ac:layout,ac:layout-section,ac:layout-cell을 투명 래퍼로 인식하여 N → N 매핑을 보장합니다Test plan
make test-reverse-sync전체 통과 (16 + 42 = 58 tests)python3 -m pytest tests/전체 통과 확인 (워크트리에서는 var/ 캐시 부재로 3건 실패)🤖 Generated with Claude Code