Skip to content

fix(converter): trailing empty <p> separator 건너뛰기를 layout 컨테이너에 확장합니다 #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jk-kim0 merged 3 commits into from
Apr 2, 2026
Merged

fix(converter): trailing empty <p> separator 건너뛰기를 layout 컨테이너에 확장합니다 #971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96e4a18
fix(converter): _is_trailing_empty_p를 ac:layout 계열 컨테이너에도 적용합니다
jk-kim0 Apr 2, 2026
b6c78ed
fix: 토론 리뷰 결과 반영 (라운드 1)
jk-kim0 Apr 2, 2026
f821f48
fix: 토론 리뷰 결과 반영 (라운드 1)
jk-kim0 Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions confluence-mdx/bin/converter/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,14 +689,18 @@ def _is_trailing_empty_p(node):
Trailing empty <p> 앞의 separator를 건너뛰면 N → N으로 1:1 매핑되어
모든 trailing blank 수를 XHTML로 정확히 표현할 수 있다.

Top-level [document] 컨텍스트에서만 적용하여, expand 매크로 등
중첩 컨테이너 내부에는 영향을 주지 않는다.
Top-level [document] 및 투명 래퍼(ac:layout 계열) 컨텍스트에서
적용하여, expand 매크로 등 중첩 컨테이너 내부에는 영향을 주지 않는다.
"""
_TRANSPARENT_PARENTS = frozenset((
'[document]',
'ac:layout', 'ac:layout-section', 'ac:layout-cell',
))
if node.name not in ('p', 'div'):
return False
if node.get_text(strip=True):
return False
if node.parent.name != '[document]':
if node.parent.name not in _TRANSPARENT_PARENTS:
return False
for sibling in node.next_siblings:
if isinstance(sibling, NavigableString):
Expand Down
2 changes: 0 additions & 2 deletions confluence-mdx/tests/reverse-sync/544112828/improved.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,6 @@ Agent &gt; Settings
</figcaption>
</figure>


#### (Mac) 메뉴 막대 내 앱 메뉴에서 초기화

메뉴 막대에서 QueryPie Agent 아이콘을 클릭하여 앱 메뉴를 엽니다. `Reset All Settings` 버튼을 클릭합니다.
Expand All @@ -313,4 +312,3 @@ Agent &gt; App menu
</figcaption>
</figure>


2 changes: 0 additions & 2 deletions confluence-mdx/tests/reverse-sync/544112828/original.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,6 @@ Agent &gt; Settings
</figcaption>
</figure>


#### (Mac) 메뉴 막대 내 앱 메뉴에서 초기화

메뉴 막대에서 QueryPie Agent 아이콘을 클릭하여 앱 메뉴를 엽니다. `Reset All Settings` 버튼을 클릭합니다.
Expand All @@ -313,4 +312,3 @@ Agent &gt; App menu
</figcaption>
</figure>


1 change: 0 additions & 1 deletion confluence-mdx/tests/reverse-sync/544178422/original.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,4 +205,3 @@ Server Group 상세 페이지 내 Accounts &gt; Secret Store 선택
* Export a file with Encryption : 파일 다운로드 시 암호 입력 여부
* Required 선택 시, 파일 다운로드 시에 파일 암호 지정 필수


2 changes: 0 additions & 2 deletions confluence-mdx/tests/testcases/544112828/expected.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,6 @@ Agent &gt; Settings
</figcaption>
</figure>


#### (Mac) 메뉴 막대 내 앱 메뉴에서 초기화

메뉴 막대에서 QueryPie Agent 아이콘을 클릭하여 앱 메뉴를 엽니다. `Reset All Settings` 버튼을 클릭합니다.
Expand All @@ -306,4 +305,3 @@ Agent &gt; App menu
</figcaption>
</figure>


Loading
Loading