-
Notifications
You must be signed in to change notification settings - Fork 9
Implement a custom SELECT with SAMPLE BY support #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@nwoolmer I'm making this a non-draft even docs is still missing, I believe impl is now alright. your review is very much appreciated!
|
nwoolmer
approved these changes
May 12, 2025
TODO:
- tests, including both sqlalchemy 1.4 and 2.0 and in combination with other clauses (GROUP BY etc)
- documentation
Example usage:
```python
from sqlalchemy import create_engine, MetaData, Table, Column
from questdb_connect import (
Timestamp,
Double,
Symbol,
)
from sqlalchemy import func
from questdb_connect import select
engine = create_engine('questdb://admin:quest@localhost:8812/main')
metadata = MetaData()
# Define a table for sensor readings
sensors = Table(
'sensors',
metadata,
Column('ts', Timestamp),
Column('temperature', Double),
Column('humidity', Double),
Column('location', Symbol),
)
def main():
metadata.create_all(engine)
location_samples = select(
sensors.c.ts,
func.avg(sensors.c.temperature).label('avg_temp'),
func.min(sensors.c.temperature).label('min_temp'),
func.max(sensors.c.temperature).label('max_temp')
).where(
sensors.c.location == 'warehouse'
).sample_by(1, 'd');
with engine.connect() as conn:
for row in conn.execute(location_samples).fetchall():
print(f"Time: {row.ts}, Average Temp: {row.avg_temp}, Minimal Temp: {row.min_temp}, Maximal Temp: {row.max_temp}")
if __name__ == '__main__':
main()
```
this impl no longer depends on SQL Text post-processing and uses clause rendering instead. this makes it more robust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
align to ... + offsetspolish APItests, including both sqlalchemy 1.4 and 2.0 and in combination with other clauses (GROUP BY etc)Example usage: