chore(web-console): product button as reported by the database#165
Merged
bluestreak01 merged 5 commits intomainfrom Jun 23, 2023
Merged
chore(web-console): product button as reported by the database#165bluestreak01 merged 5 commits intomainfrom
bluestreak01 merged 5 commits intomainfrom
Conversation
insmac
previously approved these changes
Jun 23, 2023
Contributor
insmac
left a comment
insmac
left a comment
There was a problem hiding this comment.
All good, works great!
The only comment I would have is that when there would be an accidental typo within the matched regex, i.e. QuestDB Enerprise (lack of t) or anything else that's inside core/pom.xml (I believe that's when the product name goes in), it will result in a crash of the application:
But that shouldn't be a problem, I presume this kind of error can be caught before it reaches maven/homebrew/docker etc.
Contributor
Author
|
thanks @insmac, good catch. App shouldn't break, i'll cover this. |
bluestreak01
changed the title
prevent app crash
bluestreak01
approved these changes
Jun 23, 2023
argshook
added a commit
that referenced
this pull request
Jun 27, 2023
previous change in #165 made `BuildVersion` button show different view depending on the value of `select build`. If `select build` returns unexpected value, a fallback version `x.x.x` was used, which is not valid semver according to `compare-versions` util. Moreover, if `select build` returns an unexpected value, say, while developing QuestDB locally, it was possible for the entire web console to crash. This commit fixes this problem by using `0.0.0` instead of `x.x.x` as a fallback, and in addition has more preventative measures to reduce the chance of needing to use fallback value.
Vaibhav91one
pushed a commit
to Vaibhav91one/ui
that referenced
this pull request
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added variations of enterprise versions for the build button visible at the lower right corner.
Examples
button display depends on the output of
select buildcommand.Commit log: