fix(web-console): prevent BuildVersion button crash on unexpected value#168
Merged
bluestreak01 merged 1 commit intomainfrom Jun 29, 2023
Merged
Conversation
previous change in #165 made `BuildVersion` button show different view depending on the value of `select build`. If `select build` returns unexpected value, a fallback version `x.x.x` was used, which is not valid semver according to `compare-versions` util. Moreover, if `select build` returns an unexpected value, say, while developing QuestDB locally, it was possible for the entire web console to crash. This commit fixes this problem by using `0.0.0` instead of `x.x.x` as a fallback, and in addition has more preventative measures to reduce the chance of needing to use fallback value.
argshook
changed the title
BuildVersion button crash on unexpected value
bluestreak01
approved these changes
Jun 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored
BuildVersionbutton to prevent crashes on unexpected values and improved preventative measures. Used0.0.0instead of invalid semverx.x.xas fallback. Fixes potential crash of entire web console.Commit log:
refactor
BuildVersionbutton to prevent crash on unexpected value.previous change in chore(web-console): product button as reported by the database #165 made
BuildVersionbutton show different viewdepending on the value of
select build.If
select buildreturns unexpected value, a fallback versionx.x.xwas used, which is not valid semver according to
compare-versionsutil.
Moreover, if
select buildreturns an unexpected value, say, whiledeveloping QuestDB locally, it was possible for the entire web console
to crash.
This commit fixes this problem by using
0.0.0instead ofx.x.xas afallback, and in addition has more preventative measures to reduce the
chance of needing to use fallback value.