fix: skip OIDC state check only if not required - #596
Merged
Conversation
glasstiger
previously approved these changes
Aug 13, 2026
glasstiger
previously approved these changes
Aug 13, 2026
glasstiger
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setupOAuth2compared thestateparameter only when a state value already sat in localStorage. With none stored, it skipped the check and exchanged the code anyway. A browser that never started a login accepted any?code=sent to it.The check now runs whenever the server sets
acl.oidc.state.required, and a missing or mismatched state ends inlogout({ promptForLogin: true }).OAUTH_STATEis also cleared on every path, not only inside the old branch.