Heap-buffer-overflow in ArrayBuffer.prototype.slice #1210
Description
The following code triggers a heap buffer overflow in ArrayBuffer.prototype.slice():
let buf = new ArrayBuffer(1000, { maxByteLength: 2000 });
Object.defineProperty(buf.constructor, Symbol.species, {
value: function(len) {
buf.resize(100);
return new ArrayBuffer(len);
}
});
buf.slice(500, 1000);Steps to reproduce:
- Compile with cmake using ASAN:
cmake -B build -S . -DQJS_ENABLE_ASAN=ON
cmake --build build --parallel 12
- Run the script using
./qjs <SCRIPT_NAME>.js - It should produce the following output:
=================================================================
==7226==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60b000005354 at pc 0x7f62aac4814b bp 0x7fff25c18510 sp 0x7fff25c17cc0
READ of size 500 at 0x60b000005354 thread T0
#0 0x7f62aac4814a in __interceptor_memcpy ../../../../src/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:827
#1 0x556d5dc95096 in js_array_buffer_slice (/home/razvan/quickjs-ng/quickjs/build/qjs+0x17e096)
#2 0x556d5dc5e884 in js_call_c_function (/home/razvan/quickjs-ng/quickjs/build/qjs+0x147884)
#3 0x556d5db8010e in JS_CallInternal (/home/razvan/quickjs-ng/quickjs/build/qjs+0x6910e)
#4 0x556d5db80f23 in JS_CallInternal (/home/razvan/quickjs-ng/quickjs/build/qjs+0x69f23)
#5 0x556d5dca57c8 in js_async_function_resume (/home/razvan/quickjs-ng/quickjs/build/qjs+0x18e7c8)
#6 0x556d5dcaa968 in js_async_function_call.constprop.0 (/home/razvan/quickjs-ng/quickjs/build/qjs+0x193968)
#7 0x556d5dcaaed3 in js_execute_sync_module (/home/razvan/quickjs-ng/quickjs/build/qjs+0x193ed3)
#8 0x556d5dcacf25 in js_inner_module_evaluation (/home/razvan/quickjs-ng/quickjs/build/qjs+0x195f25)
#9 0x556d5dd36e2c in JS_EvalFunction (/home/razvan/quickjs-ng/quickjs/build/qjs+0x21fe2c)
#10 0x556d5db4a21b in main (/home/razvan/quickjs-ng/quickjs/build/qjs+0x3321b)
#11 0x7f62aaa46249 in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
#12 0x7f62aaa46304 in __libc_start_main_impl ../csu/libc-start.c:360
#13 0x556d5db4a8d0 in _start (/home/razvan/quickjs-ng/quickjs/build/qjs+0x338d0)
0x60b000005354 is located 400 bytes to the right of 100-byte region [0x60b000005160,0x60b0000051c4)
allocated by thread T0 here:
#0 0x7f62aacb78d5 in __interceptor_realloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:85
#1 0x556d5dbe52d6 in js_realloc (/home/razvan/quickjs-ng/quickjs/build/qjs+0xce2d6)
#2 0x556d5dc7f4b7 in js_array_buffer_resize (/home/razvan/quickjs-ng/quickjs/build/qjs+0x1684b7)
#3 0x556d5dc5e884 in js_call_c_function (/home/razvan/quickjs-ng/quickjs/build/qjs+0x147884)
#4 0x556d5db8010e in JS_CallInternal (/home/razvan/quickjs-ng/quickjs/build/qjs+0x6910e)
#5 0x556d5db80f23 in JS_CallInternal (/home/razvan/quickjs-ng/quickjs/build/qjs+0x69f23)
#6 0x556d5dc94011 in JS_CallConstructorInternal (/home/razvan/quickjs-ng/quickjs/build/qjs+0x17d011)
#7 0x556d5dc94cda in js_array_buffer_slice (/home/razvan/quickjs-ng/quickjs/build/qjs+0x17dcda)
#8 0x556d5dc5e884 in js_call_c_function (/home/razvan/quickjs-ng/quickjs/build/qjs+0x147884)
#9 0x556d5db8010e in JS_CallInternal (/home/razvan/quickjs-ng/quickjs/build/qjs+0x6910e)
#10 0x556d5db80f23 in JS_CallInternal (/home/razvan/quickjs-ng/quickjs/build/qjs+0x69f23)
#11 0x556d5dca57c8 in js_async_function_resume (/home/razvan/quickjs-ng/quickjs/build/qjs+0x18e7c8)
#12 0x556d5dcaa968 in js_async_function_call.constprop.0 (/home/razvan/quickjs-ng/quickjs/build/qjs+0x193968)
#13 0x556d5dcaaed3 in js_execute_sync_module (/home/razvan/quickjs-ng/quickjs/build/qjs+0x193ed3)
#14 0x556d5dcacf25 in js_inner_module_evaluation (/home/razvan/quickjs-ng/quickjs/build/qjs+0x195f25)
#15 0x556d5dd36e2c in JS_EvalFunction (/home/razvan/quickjs-ng/quickjs/build/qjs+0x21fe2c)
#16 0x556d5db4a21b in main (/home/razvan/quickjs-ng/quickjs/build/qjs+0x3321b)
#17 0x7f62aaa46249 in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
SUMMARY: AddressSanitizer: heap-buffer-overflow ../../../../src/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:827 in __interceptor_memcpy
Shadow bytes around the buggy address:
0x0c167fff8a10: fa fa fa fa fa fa 00 00 00 00 00 00 00 00 00 00
0x0c167fff8a20: 00 00 00 fa fa fa fa fa fa fa fa fa 00 00 00 00
0x0c167fff8a30: 00 00 00 00 00 00 00 00 04 fa fa fa fa fa fa fa
0x0c167fff8a40: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c167fff8a50: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
=>0x0c167fff8a60: fa fa fa fa fa fa fa fa fa fa[fa]fa fa fa fa fa
0x0c167fff8a70: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c167fff8a80: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c167fff8a90: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c167fff8aa0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c167fff8ab0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
Addressable: 00
Partially addressable: 01 02 03 04 05 06 07
Heap left redzone: fa
Freed heap region: fd
Stack left redzone: f1
Stack mid redzone: f2
Stack right redzone: f3
Stack after return: f5
Stack use after scope: f8
Global redzone: f9
Global init order: f6
Poisoned by user: f7
Container overflow: fc
Array cookie: ac
Intra object redzone: bb
ASan internal: fe
Left alloca redzone: ca
Right alloca redzone: cb
==7226==ABORTING