Skip to content

Fix length check in Array.prototype.resize #1211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2025
Merged

Fix length check in Array.prototype.resize #1211

merged 1 commit into from
Oct 21, 2025

Conversation

@bnoordhuis
Copy link
Contributor

@bnoordhuis bnoordhuis commented Oct 20, 2025

Fixes: #1210

@bnoordhuis bnoordhuis mentioned this pull request Oct 20, 2025
Closed
@bnoordhuis bnoordhuis merged commit 03f7500 into quickjs-ng:master Oct 21, 2025
127 checks passed
@bnoordhuis bnoordhuis deleted the fix1210 branch October 21, 2025 10:07
@bnoordhuis
Copy link
Contributor Author

bnoordhuis commented Oct 21, 2025 •
edited
Loading

@saghul I just noticed I spelled "slice" as "resize"... how do you feel about me force-pushing a fixed commit log?

edit: I went and did it because what good are administrative superpowers if you don't (ab)use them. New commit: 2f6cad8

bnoordhuis added a commit that referenced this pull request Oct 21, 2025
@bnoordhuis
Fix length check in ArrayBuffer.prototype.slice (#1211)
2f6cad8 
Fixes: #1210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saghul saghul saghul approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Heap-buffer-overflow in ArrayBuffer.prototype.slice

2 participants

@bnoordhuis @saghul