perf(parser): Avoid quadratic identifier column lookup - #1630
Merged
Conversation
Contributor
|
Thanks for the PR! Looks like this mechanism should also be applied in js_parse_error. Also, could you please add a test? |
Contributor
Author
Good catch, pushed. |
saghul
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1585 introduced O(n^2) regression for minified single-line sources. Remove the backward scan and maintain a line start pointer in the lexer to make it O(1).
(With a 277KB minified single-line file perf regression I was seeing was 38x.)