Throw error when converting BigIntArray to Int8Array (#1690) - #1694
Merged
Conversation
saghul
approved these changes
Aug 25, 2026
sr5434
force-pushed
the
big_int_type_error
branch
from
September 6, 2026 22:52
49ed9b8 to
8909b45
Compare
Contributor
Author
|
Sorry, that commit was an accident. I just reverted it, so no new review is warranted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1690 by checking that types are compatible in the typed array constructor. Added a regression test.