please change the repository of macroexpand-dammit

[guicho271828]

There is a bug in macroexpand-dammit originally written by John Fremlin.
I tried to make a contact with him via email and the blog comment a few months ago but there have been no response.

Luckily the licence is Public Domain and I think there is no problem to re-distribute it here.

https://github.com/guicho271828/macroexpand-dammit

the detail of the bug is described in

https://github.com/guicho271828/macroexpand-dammit/blob/master/test.lisp

[quicklisp]

I have gotten several complaints that your changes to macroexpand-dammit break libraries that use it, specifically sexml. Can you look into fixing those issues?

[quicklisp]

Any word on this? I am inclined to revert to the original if it is not addressed.

[guicho271828]

sorry for the delayed reply, I was concentrated on the other project in this week.
I understand how macroexpand-dammit works and I think I can improve its behavior.

It was my fault that I did not tested the other systems that depends on macroexpand-dammit because the change I made to it was very small. Besides, I didn't recogonized that it is used by other systems (because it seemed old, and it is not well tested according to the documentation.) The bug is a bug but my change was not appropriate.

Ok, then, if you decide to revert it, could you rather use the branch https://github.com/guicho271828/macroexpand-dammit/tree/original-with-test than just revert it? the code in this branch is the same as the old macroexpand-dammit so it wouldn't conflict with sexml. Of cource, I will run the test in sexml and look into it how macroexpand-dammit is used.

[quicklisp]

I would like to keep your version if it can be made compatible with other projects that use macroexpand-dammit. A maintained library is better than an unmaintained library -- but only if it is compatible.

[guicho271828]

right.
Its 3AM here, so I don't do anymore today.

[quicklisp]

What is the status of this?

[quicklisp]

This has been reverted to John Fremlin's version for now.

[vigneshsarma]

HI,
I am still having issues.

Should this be a new issue?

stracktrace:

Specificaly:

6: (SB-IMPL::%READ-FROM-STRING "(asdf/defsystem:defsystem #:macroexpand-dammit\n  :components\n  ((:file \"macroexpand-dammit\")))" T NIL 0 NIL NIL)

Full stracktrace.

Package ASDF/DEFSYSTEM does not exist.

  Line: 1, Column: 24, File-Position: 24

  Stream: #<SB-IMPL::STRING-INPUT-STREAM {1006C00B33}>
   [Condition of type SB-INT:SIMPLE-READER-PACKAGE-ERROR]

Restarts:
 0: [RETRY] Retry SLIME interactive evaluation request.
 1: [*ABORT] Return to SLIME's top level.
 2: [ABORT] Abort thread (#<THREAD "worker" RUNNING {1006C9AFF3}>)

Backtrace:
  0: (SB-IMPL::READ-TOKEN #<SB-IMPL::STRING-INPUT-STREAM {1006C00B33}> #\a)
  1: (SB-IMPL::READ-MAYBE-NOTHING #<SB-IMPL::STRING-INPUT-STREAM {1006C00B33}> #\a)
  2: (SB-IMPL::READ-LIST #<SB-IMPL::STRING-INPUT-STREAM {1006C00B33}> #<unavailable argument>)
  3: (SB-IMPL::%READ-PRESERVING-WHITESPACE #<SB-IMPL::STRING-INPUT-STREAM {1006C00B33}> T NIL T)
  4: (SB-IMPL::%READ-PRESERVING-WHITESPACE #<SB-IMPL::STRING-INPUT-STREAM {1006C00B33}> T NIL NIL)
  5: (READ #<SB-IMPL::STRING-INPUT-STREAM {1006C00B33}> T NIL NIL)
  6: (SB-IMPL::%READ-FROM-STRING "(asdf/defsystem:defsystem #:macroexpand-dammit\n  :components\n  ((:file \"macroexpand-dammit\")))" T NIL 0 NIL NIL)
  7: ((LAMBDA () :IN SWANK::FROM-STRING))
  8: (SWANK::CALL-WITH-BUFFER-SYNTAX NIL #<CLOSURE (LAMBDA # :IN SWANK::FROM-STRING) {1006C00B0B}>)
  9: ((LAMBDA () :IN SWANK:INTERACTIVE-EVAL))
 10: (SWANK::CALL-WITH-RETRY-RESTART "Retry SLIME interactive evaluation request." #<CLOSURE (LAMBDA # :IN SWANK:INTERACTIVE-EVAL) {1006C00A2B}>)
 11: (SWANK::CALL-WITH-BUFFER-SYNTAX NIL #<CLOSURE (LAMBDA # :IN SWANK:INTERACTIVE-EVAL) {1006C009FB}>)
 12: (SB-INT:SIMPLE-EVAL-IN-LEXENV (SWANK:INTERACTIVE-EVAL "(asdf/defsystem:defsystem #:macroexpand-dammit\n  :components\n  ((:file \"macroexpand-dammit\")))") #<NULL-LEXENV>)
 13: (EVAL (SWANK:INTERACTIVE-EVAL "(asdf/defsystem:defsystem #:macroexpand-dammit\n  :components\n  ((:file \"macroexpand-dammit\")))"))
 14: (SWANK:EVAL-FOR-EMACS (SWANK:INTERACTIVE-EVAL "(asdf/defsystem:defsystem #:macroexpand-dammit\n  :components\n  ((:file \"macroexpand-dammit\")))") "COMMON-LISP-USER" 10)
 15: ((LAMBDA () :IN SWANK::SPAWN-WORKER-THREAD))
 16: (SWANK-BACKEND::CALL-WITH-BREAK-HOOK #<FUNCTION SWANK:SWANK-DEBUGGER-HOOK> #<FUNCTION (LAMBDA # :IN SWANK::SPAWN-WORKER-THREAD) {1002B6CF8B}>)
 17: ((FLET SWANK-BACKEND:CALL-WITH-DEBUGGER-HOOK :IN "/home/vignesh/quicklisp/dists/quicklisp/software/slime-20131003-cvs/swank-sbcl.lisp") ..)
 18: (SWANK::CALL-WITH-BINDINGS ..)
 19: ((LAMBDA () :IN SWANK::SPAWN-WORKER-THREAD))
 20: ((FLET #:WITHOUT-INTERRUPTS-BODY-986 :IN SB-THREAD:MAKE-THREAD))
 21: ((FLET SB-THREAD::WITH-MUTEX-THUNK :IN SB-THREAD:MAKE-THREAD))
 22: ((FLET #:WITHOUT-INTERRUPTS-BODY-340 :IN SB-THREAD::CALL-WITH-MUTEX))
 23: (SB-THREAD::CALL-WITH-MUTEX ..)
 24: (SB-THREAD::INITIAL-THREAD-FUNCTION)
 25: ("foreign function: call_into_lisp")
 26: ("foreign function: new_thread_trampoline")

I previously had some other issues, and had updated qucklisp using the following commands

(ql:update-all-dists)
(ql:update-client)

By the way I was following this tutorial when I got the error.

System info:

$ sbcl --version
SBCL 1.1.1.0.debian

[quicklisp]

Sorry, this is related to quicklisp/quicklisp-controller#2. I will fix it and make a new release soon.