schedule leaf searches by (priority, remaining_splits) lexicographically - #6695
Draft
Abdul-Andha wants to merge 1 commit into
Draft
schedule leaf searches by (priority, remaining_splits) lexicographically#6695Abdul-Andha wants to merge 1 commit into
Abdul-Andha wants to merge 1 commit into
Conversation
guilload
reviewed
Aug 14, 2026
|
|
||
| // Scheduling priority for leaf search execution. Negative values are allowed, | ||
| // and lower values have higher priority. Callers that omit it get priority 0. | ||
| optional int32 priority = 21; |
Member
There was a problem hiding this comment.
Suggested change
| optional int32 priority = 21; | |
| int32 priority = 21; |
No need for optional if we want to default to 0. Unless we want to semantically differentiate None from Some(0)
| // the raw IntermediateAggregationResults bytes instead. | ||
| bool skip_aggregation_finalization = 19; | ||
|
|
||
| reserved 20; |
Contributor
Author
There was a problem hiding this comment.
20 is used in pomsky. it will be easier to sync if we don't use 20, i think
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the proposed changes made in this PR.
How was this PR tested?
Describe how you tested this PR.