Retier post-change validation to per-change/per-milestone cadence#341
Merged
Conversation
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-Change Validation now runs on two tiers instead of one. Every code change gets a fast, scoped check (targeted
cargo test --lib <module>::, scopedcargo clippy/cargo fmt --check, and for frontend changeseslinton the touched files plustsc --noEmit, or the newvalidate-build:fastscript as a single convenience command). The fullbun run test:all:coverage+bun run validate-buildgates run once per feature, PR, or session end, not after every intermediate edit.This only changes cadence, not the bar: a feature or PR still isn't done until the full gates are green, and CI keeps enforcing the 100% coverage requirement on every PR exactly as before. The
Testingsection's coverage mandate is untouched; only the "always run test:all:coverage" line was scoped to milestone/PR time instead of every edit.Key changes
## Post-Change Validationin CLAUDE.md into explicit per-change (fast) and per-milestone (full) tiers.Testingsection'stest:all:coveragereminder to milestone/PR time.validate-build:fastto package.json (lint + format:check + typecheck + debugcargo build, no bundle/sign) as the convenience command for the per-change tier.Testing
bun run format:checkpasses (docs/config-only change, no source files touched).