Catalog: clarify revision link tooltip (catalog URL, not canonical URI) - #4838
Merged
Conversation
The link-icon button next to a package revision copies the catalog HTTPS URL, not a quilt+s3:// canonical package URI. Update the tooltip and toast to match what is actually placed on the clipboard. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4838 +/- ##
=======================================
Coverage 45.62% 45.62%
=======================================
Files 831 831
Lines 33597 33597
Branches 5727 5727
=======================================
Hits 15328 15328
Misses 16264 16264
Partials 2005 2005
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kevinemoore
approved these changes
Apr 20, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Apr 20, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RevisionInfocopies the catalog HTTPS URL (e.g.https://<catalog>/b/<bucket>/packages/<ns>/<pkg>/tree/<hash>/), but the tooltip and toast called it a "canonical URI" — which users reasonably read as aquilt+s3://package URI.Original feature: #1990 (2020). The label has been misleading since it was introduced.
Test plan
🤖 Generated with Claude Code
Greptile Summary
This PR fixes a misleading label in
RevisionInfo.tsxby renaming the tooltip and toast text from "canonical URI" / "canonical catalog URI" to "catalog URL", correctly reflecting that the copied value is a catalog HTTPS deep-link, not aquilt+s3://URI. No behavior or logic changes.Confidence Score: 5/5
Safe to merge — purely cosmetic label fix with no code logic changes.
All three changes are string literals in UI text (one toast message, two tooltip titles). No runtime behavior, data flow, or API contracts are affected. No P0/P1 findings.
No files require special attention.
Important Files Changed
titleattributes updated from "canonical URI/catalog URI" to "catalog URL". No logic, API, or behavior changes.Sequence Diagram
sequenceDiagram actor User participant IconButton participant Clipboard participant Toast User->>IconButton: hover IconButton-->>User: tooltip "Copy package revision's catalog URL to the clipboard" User->>IconButton: click IconButton->>Clipboard: copyToClipboard(getHttpsUri(hash)) IconButton->>Toast: push("Catalog URL copied to clipboard") Toast-->>User: "Catalog URL copied to clipboard"Reviews (1): Last reviewed commit: "Catalog: clarify revision link tooltip (..." | Re-trigger Greptile