Skip to content

Catalog: clarify revision link tooltip (catalog URL, not canonical URI) - #4838

Merged
drernie merged 1 commit into
masterfrom
fix-revision-link-tooltip
Apr 20, 2026
Merged

Catalog: clarify revision link tooltip (catalog URL, not canonical URI)#4838
drernie merged 1 commit into
masterfrom
fix-revision-link-tooltip

Conversation

@drernie

@drernie drernie commented Apr 20, 2026

Copy link
Copy Markdown
Member

Summary

  • The link-icon button next to a package revision in RevisionInfo copies the catalog HTTPS URL (e.g. https://<catalog>/b/<bucket>/packages/<ns>/<pkg>/tree/<hash>/), but the tooltip and toast called it a "canonical URI" — which users reasonably read as a quilt+s3:// package URI.
  • Retitle tooltip and toast to say "catalog URL" so the label matches what lands on the clipboard. No behavior change.

Original feature: #1990 (2020). The label has been misleading since it was introduced.

Test plan

  • Open a package revision in the catalog; hover the link icon next to the revision — tooltip reads "Copy package revision's catalog URL to the clipboard"
  • Click it — toast reads "Catalog URL copied to clipboard"; clipboard contains the catalog deep-link URL
  • Same checks from the revision list popover

🤖 Generated with Claude Code

Greptile Summary

This PR fixes a misleading label in RevisionInfo.tsx by renaming the tooltip and toast text from "canonical URI" / "canonical catalog URI" to "catalog URL", correctly reflecting that the copied value is a catalog HTTPS deep-link, not a quilt+s3:// URI. No behavior or logic changes.

Confidence Score: 5/5

Safe to merge — purely cosmetic label fix with no code logic changes.

All three changes are string literals in UI text (one toast message, two tooltip titles). No runtime behavior, data flow, or API contracts are affected. No P0/P1 findings.

No files require special attention.

Important Files Changed

Filename Overview
catalog/app/containers/Bucket/PackageTree/RevisionInfo.tsx Three string-only changes: toast message and two tooltip title attributes updated from "canonical URI/catalog URI" to "catalog URL". No logic, API, or behavior changes.

Sequence Diagram

sequenceDiagram
    actor User
    participant IconButton
    participant Clipboard
    participant Toast

    User->>IconButton: hover
    IconButton-->>User: tooltip "Copy package revision's catalog URL to the clipboard"
    User->>IconButton: click
    IconButton->>Clipboard: copyToClipboard(getHttpsUri(hash))
    IconButton->>Toast: push("Catalog URL copied to clipboard")
    Toast-->>User: "Catalog URL copied to clipboard"
Loading

Reviews (1): Last reviewed commit: "Catalog: clarify revision link tooltip (..." | Re-trigger Greptile

The link-icon button next to a package revision copies the catalog
HTTPS URL, not a quilt+s3:// canonical package URI. Update the tooltip
and toast to match what is actually placed on the clipboard.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@codecov

codecov Bot commented Apr 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 45.62%. Comparing base (ad91b95) to head (4cb8c64).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...app/containers/Bucket/PackageTree/RevisionInfo.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4838   +/-   ##
=======================================
  Coverage   45.62%   45.62%           
=======================================
  Files         831      831           
  Lines       33597    33597           
  Branches     5727     5727           
=======================================
  Hits        15328    15328           
  Misses      16264    16264           
  Partials     2005     2005           
Flag Coverage Δ
api-python 93.14% <ø> (ø)
catalog 19.52% <0.00%> (ø)
lambda 96.63% <ø> (ø)
py-shared 98.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@drernie drernie self-assigned this Apr 20, 2026
@drernie
drernie requested review from fiskus, kevinemoore and nl0 April 20, 2026 19:26
@drernie
drernie enabled auto-merge April 20, 2026 19:27
@drernie
drernie added this pull request to the merge queue Apr 20, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 20, 2026
@drernie
drernie added this pull request to the merge queue Apr 20, 2026
Merged via the queue into master with commit 187c1ec Apr 20, 2026
44 of 46 checks passed
@drernie
drernie deleted the fix-revision-link-tooltip branch April 20, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants