Update ROI 2019 dataset ahead of Island of Ireland merge#699
Open
claudiavalkenier wants to merge 2 commits into
Open
Update ROI 2019 dataset ahead of Island of Ireland merge#699claudiavalkenier wants to merge 2 commits into
claudiavalkenier wants to merge 2 commits into
Conversation
3 tasks
kndehaan
reviewed
Jul 8, 2026
Member
There was a problem hiding this comment.
All the required files seem correct and the commit messages are generally clear. However, for quite some values it is difficult or not possible to trace how the value is determined.
For example:
- fields:
- input_energy_chp_ultra_supercritical_ht_lignite_production
message:
"Derived from the energy balance (2019)."
- fields:
- input_energy_chp_local_engine_ht_network_gas_production
message:
"Derived from the SEAI energy balance (2019). Natural gas input for CHP plants: 264 ktoe."
Even though the source is provided, I can't trace it back easily. That is why we often create a source analysis file (excel) on ETDataset where users or contributors can trace back exactly how the data is determined. See for example the source analysis folder for Norway.
Could you add a source analysis file for Northern Ireland that contains the updated keys and gives insight in the calculations, where relevant, and the table exports (e.g. of energy balance values or Eurostat tables).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
As part of a project to combine the Republic of Ireland (ROI) and Northern Ireland datasets into a single Island of Ireland dataset, this PR refines the existing ROI 2019 dataset.
Related
Checklist
Tagging @kndehaan as reviewer