Skip to content

Update ROI 2019 dataset ahead of Island of Ireland merge#699

Open
claudiavalkenier wants to merge 2 commits into
masterfrom
updateROI2019_IE_2026
Open

Update ROI 2019 dataset ahead of Island of Ireland merge#699
claudiavalkenier wants to merge 2 commits into
masterfrom
updateROI2019_IE_2026

Conversation

@claudiavalkenier

@claudiavalkenier claudiavalkenier commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Context

As part of a project to combine the Republic of Ireland (ROI) and Northern Ireland datasets into a single Island of Ireland dataset, this PR refines the existing ROI 2019 dataset.

Related

Checklist

  • I have tested these changes
  • I have updated documentation as needed
  • I have tagged the relevant people for review

Tagging @kndehaan as reviewer

@kndehaan kndehaan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the required files seem correct and the commit messages are generally clear. However, for quite some values it is difficult or not possible to trace how the value is determined.

For example:

- fields:
  - input_energy_chp_ultra_supercritical_ht_lignite_production
  message:
    "Derived from the energy balance (2019)."

- fields:
  - input_energy_chp_local_engine_ht_network_gas_production
  message:
    "Derived from the SEAI energy balance (2019). Natural gas input for CHP plants: 264 ktoe."

Even though the source is provided, I can't trace it back easily. That is why we often create a source analysis file (excel) on ETDataset where users or contributors can trace back exactly how the data is determined. See for example the source analysis folder for Norway.

Could you add a source analysis file for Northern Ireland that contains the updated keys and gives insight in the calculations, where relevant, and the table exports (e.g. of energy balance values or Eurostat tables).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants