Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
antw
reviewed
Dec 5, 2019
Contributor
|
@antw Is it ok if I merge this? |
antw
approved these changes
Dec 6, 2019
antw
pushed a commit
that referenced
this pull request
Dec 6, 2019
* Read queries from yml, and create format for csv * Create download from gquery-response and csv format * Valid_report_names should not contain empty strings * Add/remove empty lines * Resolving hound comments * Resolving more hound comments * More hound comments * Some minor improvements to the CSV and refactors * adressed PR comments * linter fix * fixed tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested by @MartLubben. Create a csv report based on a yml file containing queries (should be in config/saved_scenario_reports). The report can be found only through url, because it's only valid for Over Morgen.
In the future, more types of reports based on different queries can be created by simply adding a yml file to the config/saved_scenario_reports folder.