Adding other sector to Industry and energy section in co2 sheet#4443
Merged
kaskranenburgQ merged 2 commits intomasterfrom Mar 31, 2025
Merged
Adding other sector to Industry and energy section in co2 sheet#4443kaskranenburgQ merged 2 commits intomasterfrom
kaskranenburgQ merged 2 commits intomasterfrom
Conversation
noracato
reviewed
Mar 20, 2025
Member
noracato
left a comment
noracato
left a comment
There was a problem hiding this comment.
Hey! Yes, that's correct. The dataset.html.haml is the base HTML file for the co2 sheet. Not sure why it's called like that though, slightly confusing 🤷♀️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves the quick fix as proposed in ETSource #3217 by adding the emissions of the Other sector to the Industry & Energy sectors.
@noracato I also updated the file: app/views/pages/dataset.html.haml, since the old querie was mentioned in this file, could you tell me whether this is necessary or whether the file is outdated?
Goes together with:
quintel/etsource#3236