External coupling co2 emissions: - #3487
Conversation
- Steel - Fertilizers transformations - Refineries transformations - Chemicals other transformations
Based on PR review Claude
| - input.co2 = 1.0 | ||
| - use = energetic | ||
| - scaling_exempt = true | ||
| - use = non_energetic |
There was a problem hiding this comment.
use should be the same for the energy node counterpart, which is energetic for the steel node. Could you change this here?
|
|
||
| - groups = [preset_demand, direct_emissions] | ||
| - input.co2 = 1.0 | ||
| - scaling_exempt = true |
There was a problem hiding this comment.
After second thought, I don't think we need the scaling_exempt defined on the four molecule nodes. scaling_exempt was needed for the other molecule nodes since they read a dataset value in the ~ demand line. A scaling was done for derived datasets (e.g. other country datasets), which was undesired. This was avoided with scaling_exempt = true.
For the four molecule nodes, however, the demand is set to 0, so I think scaling would not be applied.
Could you test whether the line can be removed by removing it, setting values for the related input and see if you get strange results that might be related to the removed line. Test this please for both a full dataset (e.g. nl2023) and few derived datasets (other countries). If nothing strange happens, you can remove this line on all four molecule nodes.
If the attribute can be removed, you can also remove the docstring about this.
| - use = non_energetic | ||
| - sector_label = industry_fertilizers | ||
|
|
||
| ~ demand = 0 |
There was a problem hiding this comment.
Could you apply a float here (0.0), and also to the other molecule nodes?
|
General discussion points:
|
2 participants
Context
Implemented changes
External coupling co2 emissions:
Related
Goes with pull requests:
Checklist