Skip to content

Conversation

@sbearrows
Copy link
Contributor

Initial pull request draft. Let's work on this together!

@sbearrows sbearrows marked this pull request as ready for review June 14, 2021 19:46
Copy link
Member

@jimhester jimhester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should number the FAQ entries, and I would put each question in a header, e.g. #### or ### so they they are linkable.


#### 8. How can I tell whether a vector is named?

TODO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can update this now with x.named() right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! 👍

@sbearrows
Copy link
Contributor Author

I think the fix for #195 caused faq 10 to not work as before so I've changed it a bit but I may be mistaken!

}
```

* Otherwise this will return a 0 length logical vector:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this, it was a recent change in behavior, but I think we have better behavior now!

@jimhester jimhester merged commit 097669f into r-lib:master Jul 1, 2021
@sbearrows sbearrows deleted the docs-add_cpp11_faq branch July 6, 2021 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants