Skip to content

Conversation

@jimhester
Copy link
Member

Fixes #187

@jimhester jimhester force-pushed the logicals-init-list branch from 17de807 to e7151ab Compare June 28, 2021 14:52
@jimhester
Copy link
Member Author

@sbearrows this seems to be sufficient to fix #187. I removed some existing initializer_list<> overloads that no longer seem necessary, as r_string objects can be constructed from const char* nad std::string. These overloads were causing the problem with g++ 5 as the compiler was either picking these instead of the r_bool one for false for some reason (possibly a compiler bug).

In any case removing these overloads seems to resolve this and the constructor we want is should now be found.

@jimhester jimhester requested a review from sbearrows June 28, 2021 14:55
Copy link
Contributor

@sbearrows sbearrows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jimhester jimhester merged commit 532cd3f into master Jun 29, 2021
@jimhester jimhester deleted the logicals-init-list branch June 29, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

false not currently working for Windows and Ubuntu platforms

3 participants