Drop skip_if_not_r_version for skip_unless_r #2988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2988 +/- ##
=======================================
Coverage 99.24% 99.24%
=======================================
Files 128 128
Lines 7267 7267
=======================================
Hits 7212 7212
Misses 55 55 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bisaloo
approved these changes
Dec 7, 2025
Collaborator
Bisaloo
left a comment
Bisaloo
left a comment
There was a problem hiding this comment.
I don't have big concerns about requiring more recent versions of packages as long as they don't bump the recursive minimum R version dependency. So all good here.
On top of this, testthat is just in Suggests so the risk is minimal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is from the very recent (November '25) {testthat} release.
We might just leave this PR pending for a while to let that version bake, OTOH, {lintr} was also just released with no immediate plans for its own CRAN push.