Skip to content

Drop skip_if_not_r_version for skip_unless_r #2988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichaelChirico merged 1 commit into from
Dec 7, 2025
Merged

Drop skip_if_not_r_version for skip_unless_r #2988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ Suggests:
rlang,
rmarkdown,
rstudioapi (>= 0.2),
testthat (>= 3.2.1),
testthat (>= 3.3.0),
tibble,
tufte,
withr (>= 2.5.0)
Expand Down
6 changes: 0 additions & 6 deletions tests/testthat/helper.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,6 @@ with_config <- function(contents, code, config_dir = ".", filename = ".lintr") {
code
}

skip_if_not_r_version <- function(min_version) {
if (getRversion() < min_version) {
testthat::skip(paste("R version at least", min_version, "is required"))
}
}

skip_if_not_utf8_locale <- function() {
testthat::skip_if_not(l10n_info()[["UTF-8"]], "Not a UTF-8 locale")
}
Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/test-one_call_pipe_linter.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ test_that("Native pipes are handled as well", {
})

test_that("one_call_pipe_linter skips data.table chains with native pipe", {
skip_if_not_r_version("4.3.0")
skip_unless_r(">= 4.3.0")

linter <- one_call_pipe_linter()
lint_msg <- rex::rex("Avoid pipe |> for expressions with only a single call.")
Expand Down
Loading