Unify sitrep and check

[hadley]

• Introduce new check_urls() function that reports on url problems with errors and call it in check_pkgdown()
• pkgdown_sitrep() now calls the same functions as check_pkgdown() but wrapped in a helper to convert errors to messages
• check_built() is a separate concern so it's moved to a separate file

Fixes #2463. Fixes #2380.

[github-actions]

🚀 Deployed on https://663e8f755f644a566a002a74--pkgdown-dev.netlify.app

[hadley]

@jayhesselberth do you think you might have time to take a look at this next week?

[jayhesselberth]

with pkgdown_sitrep(), errors in the url and reference sections are infomative; errors in the articles section are not (I made one entry in each section a blank).

And the vignette link doesn't work, see below for the same issue.

# some misconfigured yaml
url: h

articles:
- title: Customise your site
  navbar: ~
  contents:
  - customise
  - linking
  -
  - metadata

reference:
- title: Build
  desc:  Build a complete site or one of its components.
  contents:
  - build_site
  - starts_with("build_")
  - -build_site_github_pages
  - init_site
  -
  - pkgdown_sitrep

── Sitrep ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
✖ URLs not ok.
  DESCRIPTION URL lacks package url (h).
  See details in pkgdown::metadata.
✔ Open graph metadata ok.
✖ Articles metadata not ok.
  In index: 1.
✖ Reference metadata not ok.
  Section "Build": contents 5 is empty.
  Edit _pkgdown.yml to fix the problem.

[jayhesselberth]

check_pkgdown() output looks good, but the vignette link doesn't work when I click it (maybe an issue with my local install)?

> pkgdown::check_pkgdown()
Error in `pkgdown::check_pkgdown()`:
! DESCRIPTION URL lacks package url (h).
ℹ See details in pkgdown::metadata.
Run `rlang::last_trace()` to see where the error occurred.
Error: vignette ‘metadata’ not found

[jayhesselberth]

see comments

[hadley]

I suspect the vignette link doesn't work because the package hasn't been installed from CRAN, and thus doesn't have a built vignette. That code comes from cli, so I think is reliable.

I'll take a look at the other issue; it's not directly related to the check/sitrep unification, but I might as well fix it while I'm here.

[hadley]

With latest changes you now see

✖ URLs not ok.
  _pkgdown.yml lacks url.
  See details in pkgdown::metadata.
✔ Open graph metadata ok.
✖ Articles metadata not ok.
  Section "Customise your site": contents 3 is empty.
  Edit _pkgdown.yml to fix the problem.
✖ Reference metadata not ok.
  Section "Build": contents 2 is empty.
  Edit _pkgdown.yml to fix the problem.

[jayhesselberth]

Looks good to merge.