Conversation
maelle
reviewed
May 10, 2024
Collaborator
maelle
left a comment
maelle
left a comment
There was a problem hiding this comment.
maybe it's worth parsing the image paths in an attempt to guess at the chunk label? Not sure how useful that will be more people, given that the structure is pretty simple.
I feel it could be the work of some package external to pkgdown, that'd do some sort of static analysis of R Markdown/Quarto files, especially as really parsing chunk options (instead of guessing) might require new dependencies? The message that pkgdown would output after this PR seems already very informative to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to merge after #2518 (since the vignette will need a small update) and #2516 (since
check_built()has moved).Fixes #2357
@maelle maybe it's worth parsing the image paths in an attempt to guess at the chunk label? Not sure how useful that will be more people, given that the structure is pretty simple.