Skip to content

new FailReporter#308

Merged
hadley merged 5 commits into
r-lib:masterfrom
krlmlr:fail-reporter
Feb 18, 2016
Merged

new FailReporter#308
hadley merged 5 commits into
r-lib:masterfrom
krlmlr:fail-reporter

Conversation

@krlmlr
Copy link
Copy Markdown
Member

@krlmlr krlmlr commented Oct 4, 2015

single purpose: fail at end if any errors or failures were detected

Difference to StopReporter: The latter stops immediately, the new reporter proceeds until end of tests.

Kirill Müller added 4 commits October 4, 2015 20:45
@krlmlr
Copy link
Copy Markdown
Member Author

krlmlr commented Nov 10, 2015

This works best with #307 (reporter = "summary+fail"). Am I missing a better way?

@krlmlr
Copy link
Copy Markdown
Member Author

krlmlr commented Jan 26, 2016

Probably this should be default behavior for all reporters. Think about implementing that logic in the code that calls end_reporter().

@krlmlr
Copy link
Copy Markdown
Member Author

krlmlr commented Feb 18, 2016

Merged with master. Should the StopReporter stop after the first event (error/failure/warning), and not wait until the end of the test?

@hadley hadley merged commit 7cb64d3 into r-lib:master Feb 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants