New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new FailReporter #308

Merged
merged 5 commits into from Feb 18, 2016

Conversation

Projects
None yet
2 participants
@krlmlr
Member

krlmlr commented Oct 4, 2015

single purpose: fail at end if any errors or failures were detected

Difference to StopReporter: The latter stops immediately, the new reporter proceeds until end of tests.

Kirill Müller added some commits Oct 4, 2015

Kirill Müller
new FailReporter
single purpose: fail at end if any errors or failures were detected
Kirill Müller
Kirill Müller
@krlmlr

This comment has been minimized.

Member

krlmlr commented Nov 10, 2015

This works best with #307 (reporter = "summary+fail"). Am I missing a better way?

@krlmlr

This comment has been minimized.

Member

krlmlr commented Jan 26, 2016

Probably this should be default behavior for all reporters. Think about implementing that logic in the code that calls end_reporter().

@krlmlr

This comment has been minimized.

Member

krlmlr commented Feb 18, 2016

Merged with master. Should the StopReporter stop after the first event (error/failure/warning), and not wait until the end of the test?

@hadley hadley merged commit 7cb64d3 into r-lib:master Feb 18, 2016

1 check failed

continuous-integration/appveyor/pr AppVeyor was unable to build non-mergeable pull request
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment