Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,6 @@ Suggests:
spelling (>= 1.2),
styler (>= 1.2.0),
testthat (>= 3.0.0)
RdMacros:
lifecycle
Encoding: UTF-8
Language: en-US
LazyData: true
Expand Down
2 changes: 1 addition & 1 deletion R/ci.R
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#'
#' @description
#'
#' \lifecycle{soft-deprecated}
#' `r lifecycle::badge("deprecated")`
#'
#' Some of these functions are now soft-deprecated since the tidyverse team has
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#' Some of these functions are now soft-deprecated since the tidyverse team has
#' Some of these functions are now deprecated since the tidyverse team has

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we actually deprecate these, i.e. in the code? Right now the deprecation is just a state of mind.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soft deprecation is still a thing; it just doesn't get it's own badge; and it looks like use_travis() is already calling deprecate_soft()?

#' started using [GitHub Actions (GHA)](https://github.com/features/actions) for
Expand Down
2 changes: 0 additions & 2 deletions R/data-table.R
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
#'
#' @description
#'
#' `r lifecycle::badge("questioning")`
#'
#' `use_data_table` facilitates importing the data.table package by handling
#' up-front some common set-up tasks for using it in your package.
#'
Expand Down
8 changes: 4 additions & 4 deletions R/github-labels.R
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@
#' * `good first issue` indicates a good issue for first-time contributors.
#' * `help wanted` indicates that a maintainer wants help on an issue.
#'
#' @param repo_spec,host,auth_token \lifecycle{defunct}: These arguments are
#' now deprecated and will be removed in the future. Any input provided via
#' these arguments is not used. The target repo, host, and auth token are all
#' now determined from the current project's Git remotes.
#' @param repo_spec,host,auth_token `r lifecycle::badge("deprecated")`: These
#' arguments are now deprecated and will be removed in the future. Any input
#' provided via these arguments is not used. The target repo, host, and auth
#' token are all now determined from the current project's Git remotes.
#' @param labels A character vector giving labels to add.
#' @param rename A named vector with names giving old names and values giving
#' new names.
Expand Down
16 changes: 8 additions & 8 deletions R/github.R
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,11 @@
#' For a hypothetical GitHub Enterprise instance, either
#' "https://github.acme.com/api/v3" or "https://github.acme.com" is
#' acceptable.
#' @param auth_token,credentials \lifecycle{defunct}: No longer consulted now
#' that usethis uses the gert package for Git operations, instead of git2r;
#' gert relies on the credentials package for auth. The API requests are now
#' authorized with the token associated with the `host`, as retrieved by
#' [gh::gh_token()].
#' @param auth_token,credentials `r lifecycle::badge("deprecated")`: No longer
#' consulted now that usethis uses the gert package for Git operations,
#' instead of git2r; gert relies on the credentials package for auth. The API
#' requests are now authorized with the token associated with the `host`, as
#' retrieved by [gh::gh_token()].
#'
#' @export
#' @examples
Expand Down Expand Up @@ -176,9 +176,9 @@ use_github <- function(organisation = NULL,
#' an interactive session, the user can confirm which repo to use for the
#' links. In a noninteractive session, links are formed using `upstream`.
#'
#' @param host,auth_token \lifecycle{defunct}: No longer consulted now that
#' usethis consults the current project's GitHub remotes to get the `host` and
#' then relies on gh to discover an appropriate token.
#' @param host,auth_token `r lifecycle::badge("deprecated")`: No longer consulted
#' now that usethis consults the current project's GitHub remotes to get the
#' `host` and then relies on gh to discover an appropriate token.
#' @param overwrite By default, `use_github_links()` will not overwrite existing
#' fields. Set to `TRUE` to overwrite existing links.
#' @export
Expand Down
6 changes: 3 additions & 3 deletions R/release.R
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,9 @@ release_type <- function(version) {
#' need to publish the release from GitHub. It also deletes `CRAN-RELEASE` and
#' checks that you've pushed all commits to GitHub.
#'
#' @param host,auth_token \lifecycle{defunct}: No longer consulted now that
#' usethis allows the gh package to lookup a token based on a URL determined
#' from the current project's GitHub remotes.
#' @param host,auth_token `r lifecycle::badge("deprecated")`: No longer consulted
#' now that usethis allows the gh package to lookup a token based on a URL
#' determined from the current project's GitHub remotes.
#' @export
use_github_release <- function(host = deprecated(),
auth_token = deprecated()) {
Expand Down
2 changes: 1 addition & 1 deletion R/usethis-defunct.R
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ deprecate_warn_credentials <- function(whos_asking, details = NULL) {
#'
#' @description
#'
#' \lifecycle{defunct}
#' `r lifecycle::badge("deprecated")`
#'
#' In usethis v2.0.0, usethis switched from git2r to gert (+ credentials) for
#' all Git operations. This pair of packages (gert + credentials) is designed to
Expand Down
2 changes: 1 addition & 1 deletion man/ci.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 11 additions & 11 deletions man/create_from_github.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/git_credentials.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions man/use_data_table.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions man/use_github.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions man/use_github_labels.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions man/use_github_links.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions man/use_github_release.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.