Use markdown syntax for lifecycle badges #1302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennybc
reviewed
Dec 4, 2020
jennybc
approved these changes
Feb 5, 2021
| #' \lifecycle{soft-deprecated} | ||
| #' `r lifecycle::badge("deprecated")` | ||
| #' | ||
| #' Some of these functions are now soft-deprecated since the tidyverse team has |
Member
There was a problem hiding this comment.
Suggested change
| #' Some of these functions are now soft-deprecated since the tidyverse team has | |
| #' Some of these functions are now deprecated since the tidyverse team has |
Member
There was a problem hiding this comment.
Should we actually deprecate these, i.e. in the code? Right now the deprecation is just a state of mind.
Member
There was a problem hiding this comment.
Soft deprecation is still a thing; it just doesn't get it's own badge; and it looks like use_travis() is already calling deprecate_soft()?
Conflicts: R/pkgdown.R man/use_pkgdown.Rd
Member
|
Merged this to avoid future merge conflicts. I can do a separate review of calls to deprecation functions if you want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And remove RdMacros: from DESCRIPTION