Skip to content

Conversation

@hadley
Copy link
Member

@hadley hadley commented Dec 4, 2020

No description provided.

@hadley hadley requested a review from lionel- December 4, 2020 14:40
@hadley hadley merged commit 3632345 into master Dec 4, 2020
@hadley hadley deleted the lifecycle-trim branch December 4, 2020 16:27
@jennybc
Copy link
Member

jennybc commented Dec 4, 2020

This creates some self-contradiction within usethis itself. I give some examples:

The CI functions for travis and appveyor are labelled "soft-deprecated":

usethis/R/ci.R

Lines 5 to 11 in 61730df

#' \lifecycle{soft-deprecated}
#'
#' Some of these functions are now soft-deprecated since the tidyverse team has
#' started using [GitHub Actions (GHA)](https://github.com/features/actions) for
#' continuous integration (CI). See [use_github_actions()] for help configuring
#' GHA. GHA functionality in usethis is actively maintained and exercised, which
#' is no longer true for Travis-CI or AppVeyor.

I guess these become "questioning"?

We have been referring to certain functions and function arguments as "defunct":

#' @param auth_token,credentials \lifecycle{defunct}: No longer consulted now

#' @param host,auth_token \lifecycle{defunct}: No longer consulted now that

(and many more)

I guess these become "deprecated"? Do "deprecated" and "defunct" mean the same thing?

@jennybc
Copy link
Member

jennybc commented Dec 4, 2020

Yeah, reading here, it seems like we just sort of invalidated or reduced access to several stages, some of which are being used in usethis itself:

https://lifecycle.r-lib.org/articles/lifecycle.html#stages

Will these stages also be reworked / removed in the lifecycle package?

@lionel-
Copy link
Member

lionel- commented Dec 4, 2020

Given latest discussions, there is a single "deprecation" stage with three modes of communications: soft warnings, warnings, and errors. This corresponds to the deprecate_ functions in lifecycle.

From the user point of view, soft-deprecation and deprecation are the same thing. They signal a function that should no longer be used. Soft-deprecated functions should call lifecycle::deprecate_soft() but use the "deprecated" badge. I guess I should make that change in #1302.

@hadley
Copy link
Member Author

hadley commented Dec 4, 2020

@jennybc we're working on more details here: r-lib/lifecycle#63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants