Rpm/checkpoint1#3
Merged
Merged
Conversation
…? cut & pasted function and added a comment
… solutions into html but none work
…realized there were built in row,column functions
…ts on the wrong files - maybe copied the wrong repo?
…terminal app game & have the game solve itself
…workbook into rpm/checkpoint1
…but now error show up in html. error reads that start / end are not defined in html
…l onclicks into addEventListners
…can now see my actual code errors. had to re-write all variables inside of event function to accomodate event handler. no more errors from js but css has gone to shit. next need to redo css so i can see the functionality of js
…o all towers - worried this will affect move functions
…vent handler. giving up
… passing tests/not able to move
…ts. something is preventing the function from moving into movePiece
…ging parameters to startStack, endSTack
…ed corrct code to this branch. cleaned up & reduced code. got my parameters straight. had to do checkWin test using very specific .length conditional in order to pass
yousifS
reviewed
Apr 28, 2020
|
|
||
| function movePiece() { | ||
| // Your code here | ||
| function movePiece(startStack,endStack) { |
There was a problem hiding this comment.
missing additional tests
missing readme code plan file.
Owner
Author
There was a problem hiding this comment.
Hey Yousif! My README & additional tests stayed in the old file where I attempted gui: https://github.com/r-pm/javascript-workbook/tree/rpm/checkpoint1/checkpoint1
r-pm
added a commit
that referenced
this pull request
May 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checkpoint Rubric
This is the rubric that your instructor will use to grade your checkpoints. Please do not edit.
Checkpoint 1
Checkpoint 2
Checkpoint 3