L1B-02: Replace single fallback with fallback chain - #3
Merged
Conversation
- Config: `fallback_chain: list[EngineType]` replaces `fallback_engine` field (default: [gemini], preserving current behavior) - Backward compat: property `fallback_engine` reads/writes first chain element; YAML `fallback_engine` key auto-wraps into a single-element chain - Router: `select_fallback()` iterates chain in order, falls back to auto; new `select_fallback_chain()` returns full ordered list of available fallbacks - Processor: `_run_fallback()` tries each chain engine until one succeeds - Tests: 15 routing tests covering chain iteration, skipping unavailable/primary, empty chain, backward compat property, and select_fallback_chain Implements L1B-02.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fallback_engine: EngineTypewithfallback_chain: list[EngineType]in config[gemini](preserves current behavior)StandardPipeline._run_fallback()now tries each engine in the chain until one succeedsEngineRouter.select_fallback()iterates the chain; newselect_fallback_chain()returns full ordered listfallback_engineproperty wraps chain access, legacy YAML still worksTest plan