Use modules to support OpenJFX 11+, Java 11+#63
Closed
ausbin wants to merge 1 commit into
Closed
Conversation
b44d0d0 to
7135ab0
Compare
ausbin
added a commit
to ausbin/circuitsim-grader-template
that referenced
this pull request
Jan 14, 2020
ausbin
added a commit
to ausbin/circuitsim-grader-template
that referenced
this pull request
Jan 19, 2020
ausbin
added a commit
to ausbin/circuitsim-grader-template
that referenced
this pull request
Jan 19, 2020
Contributor
Author
|
Looks like 4e0a9d0 took care of this yee haw |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Roi,
I was having some trouble running CircuitSim on Java 11, so I started messing with this
Maybe you already knew about this, but apparently Java 9 introduced "modules", and OpenJFX after Java 9 is distributed as these "modules". I still don't understand the benefit of them but I'm probably just not Java-woke enough
If you run
./gradlew jlink, the "badass"jlinkplugin will generatebuild/image/bin/CircuitSim, a shell script which will launch CircuitSim../gradlew jlinkZipwill generatebuild/CircuitSim.zip, a zip you can decompress somewhere to "install" CircuitSim. SpicySeems like Java 8 will be supported for about another year, but in case it's ever time to upgrade, I hope this helps
I think this is more of a starting point, though, since
./gradlew rundoesn't work properly for example. According to./gradlew run --debug, it actually runs:Those
-Dx=yarguments and the classname at the end seem to be misplaced and are passed to CircuitSim as arguments (it tries to open each one as a circuit file and fails). I don't know if this is a bug in Gradle or the the plugin, or some kind of misconfiguration on my part.