Clean consumer stats samples differently depending on how many there are #10451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelklishin
requested changes
Feb 1, 2024
| ets:delete(IndexTable, Id), | ||
| ok; | ||
| index_delete(consumer_stats = Table, {channel = Type, Count}, Id) -> | ||
| case Count > ?LARGE_CONSUMER_COUNT of |
There was a problem hiding this comment.
We can add a comment explaining the condition here: ets:match_delete/2 is acceptable or optimal for a large number of entries on this particular channel but when there are many channels with a few (very often just one) consumers each, its sequential scans become prohibitively expensive.
michaelklishin
changed the title
michaelklishin
force-pushed
the
check_consumer_count
branch
from
7ac3f8c to
5d5cf2c
Compare
|
The forced push was a rebase. |
kjnilsson
approved these changes
Feb 2, 2024
@kjnilsson Curious, what was your idea? |
michaelklishin
added a commit
that referenced
this pull request
Feb 2, 2024
michaelklishin
added a commit
that referenced
this pull request
Feb 2, 2024
|
Merged with a cosmetic change from me in #10476 |
mergify bot
pushed a commit
that referenced
this pull request
Feb 3, 2024
(cherry picked from commit dad9379)
michaelklishin
added a commit
that referenced
this pull request
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This is a revision of #9356.
Check number of consumers for a terminated channel, If over 1000, bulk delete metrics, if under 1001, do it the old way.
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
CONTRIBUTING.mddocumentFurther Comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.