Skip to content

Conversation

@mergify
Copy link

@mergify mergify bot commented Apr 11, 2024

Proposed Changes

change control sequence modifier to allow for data in MaxConsumers variable as integer, not interpreted as string. Prevents io_lib crash when consumer max per channel is exceeded.

MaxConsumers can be either an integer or infinity, however this clause will never match if infinity, so shouldn't need to account for that.

background: #10970

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • [ X ] Bug fix (non-breaking change which fixes issue Exceeding max number of consumers per channel crashes connection #10970 )
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.


This is an automatic backport of pull request #10976 done by [Mergify](https://mergify.com).

@michaelklishin michaelklishin merged commit dee4a3e into v3.13.x Apr 12, 2024
@michaelklishin michaelklishin deleted the mergify/bp/v3.13.x/pr-10976 branch April 12, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants