Declaring an exchange with an invalid type is a precondition failure

[carlhoerberg]

Proposed Changes

Declaring an exchange with an invalid type should be a precondition failure, not a invalid command that closes the whole connection, interrupting all other channels.

Types of Changes

• Bug fix (non-breaking change which fixes issue #NNNN)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause an observable behavior change in existing systems)
• Documentation improvements (corrections, new content, etc)
• Cosmetic change (whitespace, formatting, etc)
• Build system and/or CI

Checklist

• I have read the CONTRIBUTING.md document
• I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
• I have added tests that prove my fix is effective or that my feature works
• All tests pass locally with my changes
• If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
• If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

When doing channel pooling and a single client/channel declares a bad exchange type all other channels/clients will be disconnected which doesn't makes sense imho.