4.x: remove queues filter for Prometheus collector

[LoisSotoLopez]

Proposed Changes

Removes the queue filtering for Rabbit's Prometheus metric collector since it wasn't being used as stated at #11315

Types of Changes

• Bug fix (non-breaking change which fixes issue #NNNN)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause an observable behavior change in existing systems)
• Documentation improvements (corrections, new content, etc)
• Cosmetic change (whitespace, formatting, etc)
• Build system and/or CI

Checklist

• I have read the CONTRIBUTING.md document
• I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
• I have added tests that prove my fix is effective or that my feature works
• All tests pass locally with my changes
• If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
• If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

Closes #11315

[michaelklishin]

Actions fail because google-github-actions/auth does. I suspect it may have something to do with the fact that this is an external contribution (to the GitHub org), which always messes up some permission assumptions around Actions.

[michaelklishin]

Rebasing this PR will address a few CI failures.

[LoisSotoLopez]

Did that rebase. Any other action I can help with to move this PR forward?

[michaelklishin]

I'd keep prometheus.filter_aggregated_queue_metrics_pattern. Even if it is not used, why break node startup for 4.0 when it can be easily avoided? The option can be removed in 4.1, 4.2 or something like that, that is, in a release with way fewer changes.

[michaelklishin]

Thank you.