rabbitmq_ct_helpers: Always give $RABBITMQ_FEATURE_FLAGS a value
#13104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... even if `skip_metadata_store_configuration` is given. [Why] If `skip_metadata_store_configuration` is set to true, we let the node boot with the stable feature flags all enabled. This may prevent clustering in mixed-version testing if the secondary umbrella misses a stable feature flag. [How] If `skip_metadata_store_configuration` is set, we restore the previous behavior of starting the node with the required feature flags only. I.e. all stable ones are disabled at first.
Collaborator
Author
|
This pull request is abandonned and replaced by #13099. |
dumbbell
deleted the
fix-how-RABBITMQ_FEATURE_FLAGS-is-set-in-tests-part2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… even if
skip_metadata_store_configurationis given.Why
If
skip_metadata_store_configurationis set to true, we let the node boot with the stable feature flags all enabled. This may prevent clustering in mixed-version testing if the secondary umbrella misses a stable feature flag.How
If
skip_metadata_store_configurationis set, we restore the previous behavior of starting the node with the required feature flags only. I.e. all stable ones are disabled at first.This is a follow-up to #13077.