Skip to content

rabbitmq_ct_helpers: Always give $RABBITMQ_FEATURE_FLAGS a value #13104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

rabbitmq_ct_helpers: Always give $RABBITMQ_FEATURE_FLAGS a value #13104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 32 additions & 25 deletions deps/rabbitmq_ct_helpers/src/rabbit_ct_broker_helpers.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1051,31 +1051,38 @@ configured_metadata_store(Config) ->
end.

configure_metadata_store(Config) ->
case skip_metadata_store_configuration(Config) of
true ->
ct:log("Skipping metadata store configuration as requested"),
Config;
false ->
ct:log("Configuring metadata store..."),
MetadataStore = configured_metadata_store(Config),
Config1 = rabbit_ct_helpers:set_config(
Config, {metadata_store, MetadataStore}),
FeatureNames0 = case MetadataStore of
mnesia ->
ct:log("Enabling Mnesia metadata store"),
?REQUIRED_FEATURE_FLAGS;
khepri ->
ct:log("Enabling Khepri metadata store"),
[khepri_db | ?REQUIRED_FEATURE_FLAGS]
end,
OtherFeatureNames = rabbit_ct_helpers:get_app_env(
Config,
rabbit, forced_feature_flags_on_init, []),
FeatureNames1 = lists:usort(FeatureNames0 ++ OtherFeatureNames),
rabbit_ct_helpers:merge_app_env(
Config1,
{rabbit, [{forced_feature_flags_on_init, FeatureNames1}]})
end.
{Config2,
FeatureNames0} = case skip_metadata_store_configuration(Config) of
true ->
ct:log(
"Skipping metadata store configuration as "
"requested"),
{Config, ?REQUIRED_FEATURE_FLAGS};
false ->
ct:log("Configuring metadata store..."),
MetadataStore = configured_metadata_store(
Config),
Config1 = rabbit_ct_helpers:set_config(
Config,
{metadata_store, MetadataStore}),
case MetadataStore of
mnesia ->
ct:log("Enabling Mnesia metadata store"),
{Config1,
?REQUIRED_FEATURE_FLAGS};
khepri ->
ct:log("Enabling Khepri metadata store"),
{Config1,
[khepri_db | ?REQUIRED_FEATURE_FLAGS]}
end
end,
OtherFeatureNames = rabbit_ct_helpers:get_app_env(
Config2,
rabbit, forced_feature_flags_on_init, []),
FeatureNames1 = lists:usort(FeatureNames0 ++ OtherFeatureNames),
rabbit_ct_helpers:merge_app_env(
Config2,
{rabbit, [{forced_feature_flags_on_init, FeatureNames1}]}).

skip_metadata_store_configuration(Config) ->
Skip = rabbit_ct_helpers:get_config(
Expand Down
Loading