Adding a "source-bundle" target to the Makefile (backport #13385) (backport #13395) #13396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This target is identical to the existing "source-dist" target, except that it allows for packaging and testing of the source archive. This is done by including the packaging/ and tests/ directories in the output tarball, along with specific subdirectories that are required by tests. Signed-off-by: Kartik Ganesh <gkart@amazon.com> (cherry picked from commit aa9e0a5) (cherry picked from commit ec45d93)
This incorporates PR feedback from @michaelklishin Signed-off-by: Kartik Ganesh <gkart@amazon.com> (cherry picked from commit 741e04b) (cherry picked from commit 3415fa8)
Collaborator
|
@kartg this breaks in this repo, so I will revert. I cannot immediately tell why but it can be reproduced in multiple different environments. https://github.com/rabbitmq/server-packages/actions/runs/13468260488/job/37638171804 is currently waiting for a runner but it should fail there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This change adds a
source-bundlebuild target to the RabbitMQ Makefile. This target is identical to the existingsource-disttarget but it also allows for packaging and testing of the source archive.Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
CONTRIBUTING.mddocumentThis is an automatic backport of pull request [Reverted] Adding a "source-bundle" target to the Makefile #13385 done by Mergify.
This is an automatic backport of pull request Adding a "source-bundle" target to the Makefile (backport #13385) #13395 done by Mergify.