Minor: Fix Mgmt UI local shovel delete-after #14638
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Context: Management UI > Shovel Management Tab > "Add a new shovel" section.
There was no input field to set the number for delete-after "After num messages" parameter for local shovels as opposed to AMQP 1.0 shovels.
The help text was also missing for local shovel auto-delete. (The
?showed an empty popup when Local protocol is selected for Source)The solution is just a copy past from AMQP 1.0
EDIT: now the bellow works
Setting delete-after to a number when creating a local shovel still doesn't work as the value is sent in the PUT json as a string instead of a number. Doing the same with an AMQP 1.0 works fine sending a json number. Where the conversion happens on the frontend is beyond my understanding of the Mgmt javascript. I would need some help to address this part.
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.You can also fill these out after creating the PR.
This is simply a reminder of what we are going to look for before merging your code.
CONTRIBUTING.mddocumentFurther Comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution
you did and what alternatives you considered, etc.